Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP: method expects array|string, array<int> given #6081

Closed
dktapps opened this issue Nov 24, 2021 · 2 comments
Closed

FP: method expects array|string, array<int> given #6081

dktapps opened this issue Nov 24, 2021 · 2 comments
Labels
Milestone

Comments

@dktapps
Copy link
Contributor

dktapps commented Nov 24, 2021

Bug report

This is a weird corner case that requires a combination of several factors:

  1. A function accepts mixed[]|something
  2. The function is called with an array which is known to not be empty (e.g. due to count()).

I observe the following:

  • If the count() check is removed, everything is fine.
  • If the type is merely mixed[] instead of mixed[]|something, everything is also fine.

Code snippet that reproduces the problem

https://phpstan.org/r/0eac094b-8140-414b-ad0c-f3c360a44186

Expected output

No error should be reported.

Did PHPStan help you today? Did it make you happy in any way?

It gave me a good chuckle to realize how hard this bug would have been to find intentionally.

@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jan 31, 2022
@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@9f12f0f

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants