False positive in Property Class::$property is never read, only written-rule when using empty()

[jaylinski]

Bug report

Rule Property Class::$property is never read, only written reports a false-positive when the class-property is "read" with empty().

Code snippet that reproduces the problem

https://phpstan.org/r/89c4e6d0-5ef4-492b-95fb-f0b7ed51a8ca

Expected output

There is no error when a class-property is "read" via empty().

Did PHPStan help you today? Did it make you happy in any way?

PHPStan v1 new rules are awesome. 👍

[herndlm]

Same thing with isset. I think this might be on purpose, at least I think it's helpful as in your case this could also be something like a bool property? Debatable though I guess ;)
And checking uninitialised typed properties with isset and empty does not fail in PHP. Really accessing it directly though would through a fatal error AFAIK

[jaylinski]

I think this might be on purpose, at least I think it's helpful as in your case this could also be something like a bool property

That's true. Using a non-boolean property for boolean checks is not really "good/clean" code.

An alternative error like Property Class::$property is non-boolean but only used in a boolean way (or something like this 😅) would be nice.

Also: this error doesn't happen when using is_array() or is_null().

[paranoiq]

the same problem when using null coalesce (??) https://phpstan.org/r/7804477b-a7d9-4132-a5fd-3e409ac82ace

[ondrejmirtes]

Fixed: phpstan/phpstan-src#1174

[jaylinski]

Thank you! 🥇

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.