Type changed to *NEVER*

[lulco]

Bug report

PHPStan changed type from array (in my case array{default?: int}) to *NEVER*. I discover that this behavior was introduced in version 0.12.60 (0.12.59 is OK).

Code snippet that reproduces the problem

https://phpstan.org/r/8851a26d-ccfc-43e2-95b6-acf531da1d09

Expected output

Do not change type to *NEVER*. Let it be as before.

[herndlm]

But this is correct behaviour in your example, as the path is never executable because the condition will be always false. I suspect this is making a problem somewhere in your code?

[Kocal]

How $x !== $y can be true if you have $x = $y = ... just before?

[ondrejmirtes]

It's at least a bit weird because PHPStan should report "always false" for $x !== $y.

[lulco]

I've removed parts which do nothing. Here is added some modification for $y https://phpstan.org/r/66f180f1-4352-49a9-9a3d-081f71ee2665

[phpstan-bot]

@lulco After the latest commit in 1.8.x, PHPStan now reports different result with your code snippet:

@@ @@
 19: Dumped type: array{default?: int}
-21: Dumped type: *NEVER*
+21: Dumped type: array{default?: int}

Full report

Line	Error
19	Dumped type: array{default?: int}
21	Dumped type: array{default?: int}

[phpstan-bot]

@lulco After the latest commit in 1.8.x, PHPStan now reports different result with your code snippet:

@@ @@
 22: Dumped type: array{default?: int}
-24: Dumped type: *NEVER*
+24: Dumped type: array{default?: int}

Full report

Line	Error
22	Dumped type: array{default?: int}
24	Dumped type: array{default?: int}

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.