in_array with array of literals is always true when it is possible to contain the checked value.

[BackEndTea]

Bug report

When doing an in_array check on an array with string literals, it is always true if the checked string matches one of the literals.

In both has1, has2 and has3 the type is not correct, as the array may be empty, or contain another value.

Code snippet that reproduces the problem

https://phpstan.org/r/2d2fb268-4ecd-4255-b8a2-312a0c7cbfaf

Expected output

Dumped types in order:

• bool
• bool
• bool
• true (this one is correct already)

[phpstan-bot]

@BackEndTea After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 8: Dumped type: true
-16: Dumped type: true
-24: Dumped type: true
-33: Dumped type: true
+No errors

[phpstan-bot]

@BackEndTea After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 8: Dumped type: true
-16: Dumped type: true
-24: Dumped type: true
+ 8: Dumped type: bool
+16: Dumped type: bool
+24: Dumped type: bool
 33: Dumped type: true

Full report

Line	Error
8	Dumped type: bool
16	Dumped type: bool
24	Dumped type: bool
33	Dumped type: true

[ondrejmirtes]

Fixed: phpstan/phpstan-src@4321374

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.