checkExplicitMixed - hardcoded functions in NodeScopeResolver like array_map and array_filter expect wrong callable

[ondrejmirtes]

Bug report

Code like this:

	/**
	 * @return Entity[]
	 */
	public function getSavableEntities() : array{
		return array_filter($this->entities, function(Entity $entity) : bool{ return $entity->canSaveWithChunk() and !$entity->isClosed(); });
	}

fails with:

 ------ ----------------------------------------------------------------------------------------------
  Line   src/pocketmine/level/format/Chunk.php
 ------ ----------------------------------------------------------------------------------------------
  644    Parameter #2 $callback of function array_filter expects (callable(mixed, mixed): bool)|null,
         Closure(pocketmine\entity\Entity): bool given.
 ------ ----------------------------------------------------------------------------------------------

Because the reflection layer is unaware of the "genericness".

Code snippet that reproduces the problem

checkExplicitMixed not yet supported on phpstan.org

Expected output

No errors

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@ca7deb3

[dktapps]

I'm still seeing the same bogus errors on PM with 0.12.99, e.g. https://github.com/pmmp/PocketMine-MP/pull/4457/checks?check_run_id=3585690922#step:10:9

[ondrejmirtes]

@dktapps It's fixed if you enable bleedingEdge.

[dktapps]

Is the fix that disruptive? Ouch ...

[ondrejmirtes]

The fix accidentally implements this which can be considered a new rule (many new errors reported in existing codebases): #1954

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.