Support for self::CONST_*_SUFFIX with suffixes

[Seldaek]

Feature request

I tried using a const wildcard in the middle and it blew up on me :) I assumed this would just work but it appears to be only supported as a trailing wildcard. I'm not sure if there is a good reason for this or if it's just an omission, but it would be nice if wildcards were supported anywhere in the constant name IMO.

Happy to try and send a PR if you approve of the idea and can maybe point me in the right direction, as I am not familiar with the large codebase.

[staabm]

could you show us in a code sample what you expect on the https://phpstan.org/ sandbox?

[Seldaek]

Sure https://phpstan.org/r/b84f6dba-50dd-4e59-bd37-e83826e80d88 I expect no error here :)

As you can see I couldn't simply use FOO_* in this case as it would include other constants I am not interested in, forcing me to list all of them one by one as self::FOO_BAR_BAZ|self::FOO_BOO_BAZ|...

[ondrejmirtes]

This isn't to hard too do. Two places need to be modified:

1. The parser part, original commit with * support is here: phpstan/phpdoc-parser@fde6cca
2. TypeNodeResolver here in phpstan-src, original commit: phpstan/phpstan-src@730a902 (you can see the part with Strings::endsWith($constantName, '*') which needs modification)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.