Error with PHP8 and __toString for Symfony project when use DoctrineBehaviors translation on entities

[RomulusED69]

Bug report

Hi ✋,

I have a Symfony project with https://github.com/KnpLabs/DoctrineBehaviors.
I tried to update project to PHP8 but I'm having problem with phpstan.

Bundle created its own extensions https://github.com/KnpLabs/DoctrineBehaviors/tree/master/utils/phpstan-behaviors/src/Type

No problem with PHP7.4 but with PHP8:

After investigations, problem occurs only when method __toString is defined.
Problem appears on invoke here https://github.com/KnpLabs/DoctrineBehaviors/blob/master/utils/phpstan-behaviors/src/Type/TranslationTypeHelper.php#L36

Code snippet that reproduces the problem

https://github.com/RomulusED69/phpstan-knp-doctrine-behaviors-bug

Thanks for your help

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[ondrejmirtes]

Fixed: ondrejmirtes/BetterReflection@fef40df + phpstan/phpstan-src@89ceb6a

[RomulusED69]

Thank you

[RomulusED69]

After testing, it turns out that it does not work.
In my example, TranslatableMethodsTrait, in context of Article, should return ArticleTranslation but return now Knp\DoctrineBehaviors\Model\Translatable\TranslatableMethodsTraitTranslation.

TranslatableMethodsTrait use return static::class . 'Translation';

@ondrejmirtes

[ondrejmirtes]

Hi, this is not a PHPStan bug. Looks like the extension is saying that translate() method returns TranslatableMethodsTraitTranslation, and such class does not exist. This needs to be fixed in the extension. Most likely TranslatableTranslateDynamicMethodReturnTypeExtension.

[RomulusED69]

I'm not sure.
In extension, first, they create reflexionClass like this

$reflectionClass = $broker->getClass($translatableClass)
            ->getNativeReflection();

with $translatableClass = 'Article';

$reflectionClass
            ->getMethod('getTranslationEntityClass')
            ->invoke(null);

should return ArticleTranslation but reflexion behaves as if the trait was alone without context of Article.

return static::class . 'translation'; in context of Article with Trait should return for static::class => Article but reflexion return Trait

[ondrejmirtes]

@RomulusED69 Fixed that too :) ondrejmirtes/BetterReflection@f14002e + phpstan/phpstan-src@9b51f82

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.