non-empty-string is not always truthy

[BackEndTea]

Bug report

if the length of a string is 1, it is not necessarily truthy. if it is '0', the string is fasly

Code snippet that reproduces the problem

https://phpstan.org/r/0d0ff87d-1142-4c8d-887a-9ea257c0540b
https://phpstan.org/r/af765852-8582-480e-8225-6457ee0b214e
https://3v4l.org/BeHAV

Expected output

No errors

[ondrejmirtes]

Yeah, you're right, but I think we need to introduce another type, something like non-falsy-string, because there are examples of non-empty-string where we know if's not falsy either.

[ondrejmirtes]

And it's useful to mark if ($is) as always-true if it's really the case.

[VincentLanglet]

For the record, since https://github.com/vimeo/psalm/releases/tag/4.5.0, there is a non-falsy-string type in psalm.

[phpstan-bot]

@BackEndTea After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-6: Dumped type: non-empty-string
-8: Negated boolean expression is always false.
+No errors

[phpstan-bot]

@BackEndTea After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-8: Negated boolean expression is always false.
+No errors

[VincentLanglet]

Seems fixed.
This can be closed @ondrejmirtes

[ondrejmirtes]

It's not fixed, it was a bug in the playground.

[JTAjala]

I currently have this issue with this
Is there a timeline when it will be fixed? The last activity on here was last year

the library I'm using is php-fig/http-message/StreamInterface.php eof()

[ondrejmirtes]

@JTAjala your issue is most likely unrelated, please open a separate bug report

[voku]

Here is another example:

• https://phpstan.org/r/25315666-053c-405d-b1ac-d59405571fa7
• https://3v4l.org/XUop2

[staabm]

did some research on this topic.

in psalm non-falsy-string was initially implemented with vimeo/psalm@a0420fb

for phpstan-src inspiration:

• AccessoryNumericStringType was implemented with phpstan/phpstan-src@1d27c61
• AccessoryNonEmptyStringType was implemented with phpstan/phpstan-src@6ef5e91

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.