Wrong assumption on array merge

[dereuromark]

Bug report

Code snippet that reproduces the problem

https://phpstan.org/r/86239cd8-0802-4070-8bdf-b773187103ee

	/**
	 * @param array $configs
	 *
	 * @return array
	 */	
	protected function merge(array $configs): array {
		$result = [];
		foreach ($configs as $config) {
			$result += $config;

			foreach ($config as $name => $dto) {
				$result[$name] += $dto;
			}
		}

		return $result;
	}

Expected output

no issue as long as we do not document this any further, just as before.
This didn't error a few patches before. So this looks like a too strict regression of sorts.

[ondrejmirtes]

PHPStan's error is expected, see: https://3v4l.org/QipVB

You need more specific PHPDocs telling what's in $configs.

[ondrejmirtes]

I realized what actually changed it, just a moment.

[ondrejmirtes]

But it doesn't change you should actually fix your code :) But I'll make PHPStan stop reporting this.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@2abb92e

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.