PHPStan does not expect an exception in method call in a try block.

[petaak]

Bug report

PHPStan does not expect an exception in method call in a try block. In the code snippet below, PHPStan should expect that the "test" method call can throw an exception.

Code snippet that reproduces the problem

https://phpstan.org/r/9e470be5-ea3b-461d-9a38-7a1ca66e526b

Expected output

No errors.

[ondrejmirtes]

Why it currently doesn't work: PHPStan differentiates between explicit throw points ("throw" keyword, function calls that have @throws in the declaration etc.), and implicit throw points (function calls that do not have any @throws above them and MIGHT throw an exception).

But I found out that the analysis works best if the explicit throw points have priority. My thinking is that if that if you throw something explicitly, then all the throw points in the try block should be explicit.

See the following examples that work correctly:

• All throw points are implicit: https://phpstan.org/r/4a308a0d-5732-45ac-af3c-af357503f226
• All throw points are explicit: https://phpstan.org/r/62cf7743-03aa-4b91-8149-d7a860fbb9b9

I'll fix your example for the Throwable catch block. Analysis of more specific catch blocks will not be changed.

[mrrafaj]

Hi, I have a similar problem which is difficult for me to solve. We often on entities call "get" methods after exception to get an identifier, see .. https://phpstan.org/r/995e1b4f-bdd6-4c7b-84aa-42ecfd51760d
..any ideas ? thank you

[ondrejmirtes]

@mrrafaj Your issue is most likely unrelated to this one, so pleaase open a separate issue, and always provide more accurate example. In this case PHPStan is correct. You might find out it's not a false positive and that PHPStan is in fact correct, see for example #4851 :)

[ondrejmirtes]

Fixed: phpstan/phpstan-src@54a204e

[petaak]

Thanks!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.