-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Bleeding Edge with constants visibility #4859
Comments
I'd recommend reporting this to https://github.com/timeweb/phpstan-enum instead. It's not a responsibility of PHPStan itself to account for special cases from various libraries. Cases like these should instead be taken care of by an extension in my opinion. Also you can always choose to ignore the error. |
|
It would be great 👍🏼 Are you open to a PR that implement some like this ? |
Yeah, sure, I'd like it! |
Thanks to phpstan/phpstan-src#495 it's now possible to write a custom extension to describe this :) |
Thanks for you work on this library :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature request
I'm using Bleeding Edge feature in my project which use an
Enum
library implementation (myclabs/php-enum).In my project, I don't want to expose internal constants values.
So my
Enum
looks like that:But those constants are detected as not being used event if the are (the library resolve it by using PHP magic methods).
Currently the only way to override this variables detection is to use the
ReadWritePropertiesExtension
interface, but it's not working with constants.The text was updated successfully, but these errors were encountered: