False negative with nested if in for loop

[nikophil]

Hello there,

Bug report

Here is an example of the problem.
https://phpstan.org/r/c499e9ad-92a3-47ec-91ba-42d0920dbc06

I got a false negative on this code. I know the code is far from ideal but it actually works, and moreover on the first iteration, the && result is definitely not false...

What's weird is that when you change the if in order to use CONST_2 in both part of the &&, phpstan returns 0 errors, although both parts of the && are unrelated. Or maybe i'm missing something Oo
If i split the && in order to use two nested if, I got no errors as well...

Expected output

no error should be reported.

[nikophil]

hi @ondrejmirtes

I see the "easy fixes" label, if you point me out which part of code should be updated, I can make a PR

[ondrejmirtes]

I actually don't know what's going on and why is this reported, probably the left part of the && expression influences something about the right part which shouldn't be happening. "Easy fix" just means that it will not be hard to fix, but it needs to be debugged what's going on in Scope with this situation.

[ondrejmirtes]

My tip is actually that the TypeSpecifier does something weird with this part: self::CONST_1 === $object->getType() but I can be wrong.

[phpstan-bot]

@nikophil After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Result of && is always false.
+ 9: Method HelloWorld::test() is unused.
+13: Result of && is always false.
+22: Property MyObject::$type is never written, only read.

Full report

Line	Error
9	Method HelloWorld::test() is unused.
13	Result of && is always false.
22	Property MyObject::$type is never written, only read.

[phpstan-bot]

@nikophil After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Result of && is always false.
+13: Result of && is always false.
+ 9: Method HelloWorld::test() is unused.
+22: Property MyObject::$type is never written, only read.

Full report

Line	Error
13	Result of && is always false.
9	Method HelloWorld::test() is unused.
22	Property MyObject::$type is never written, only read.

[phpstan-bot]

@nikophil After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Result of && is always false.
+ 9: Method HelloWorld::test() is unused.
+22: Property MyObject::$type is never written, only read.

Full report

Line	Error
9	Method HelloWorld::test() is unused.
22	Property MyObject::$type is never written, only read.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@4321374

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.