Not null affectation does not define variable

[alterphp]

Bug report

In a if statement, I first check that affectation of a variable is not NULL, and then try to use the variable in a second part of the condition. PHPStan output an error like Undefined variable: $affectedVar.

It could be related to #4357.

Code snippet that reproduces the problem

https://phpstan.org/r/43c76836-a07b-40ef-826f-e72c889b9024

Expected output

In the above example, PHPStan should not output that $programStartDate is undefined at line 22.

[ondrejmirtes]

Yeah, this is problematic, but you can work around this with arguably more readable code: https://phpstan.org/r/2fa5189a-4e20-4f7a-8cad-6f83c1fff0c7

[alterphp]

Actually I was pretty sure it worked before, but I cannot make it work from v0.12.60. Maybe I just dreamt about it ;-)

Thanks for hard work!

[phpstan-bot]

@alterphp After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 8: Property Foo::$programStartDate is never written, only read.
 22: Undefined variable: $programStartDate

Full report

Line	Error
8	Property Foo::$programStartDate is never written, only read.
22	Undefined variable: $programStartDate

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+8: Property Foo::$programStartDate is never written, only read.

Full report

Line	Error
8	Property Foo::$programStartDate is never written, only read.

[phpstan-bot]

@alterphp After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
+ 8: Property Foo::$programStartDate is never written, only read.
 22: Undefined variable: $programStartDate

Full report

Line	Error
8	Property Foo::$programStartDate is never written, only read.
22	Undefined variable: $programStartDate

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+8: Property Foo::$programStartDate is never written, only read.

Full report

Line	Error
8	Property Foo::$programStartDate is never written, only read.