New strange error "Cannot call method getInputHtml() on class-string|object."

[williamdes]

Bug report

Strange new error since .78 version

And the code checks if (method_exists($transformation_plugin, 'getInputHtml')) { so for me it can not be a class-string at this point 🤔

Code snippet that reproduces the problem

https://github.com/phpmyadmin/phpmyadmin/blob/58c4f3fe16f17400436946be9a82b5811439107b/libraries/classes/InsertEdit.php#L3444

https://github.com/phpmyadmin/phpmyadmin/blob/58c4f3fe16f17400436946be9a82b5811439107b/libraries/classes/InsertEdit.php#L3459

Expected output

no errors

Actual output

$ composer run phpstan
> phpstan analyse
Note: Using configuration file phpstan.neon.dist.
 733/733 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------- 
  Line   libraries/classes/InsertEdit.php                           
 ------ ----------------------------------------------------------- 
  3444   Cannot call method getInputHtml() on class-string|object.  
  3459   Cannot call method getScripts() on class-string|object.    
 ------ ----------------------------------------------------------- 

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[MartinMystikJonas]

Well if transformation_plugin is string you cannot call methods on it by - >, but it will pass the method_exists check if that string contains name of class with given method.

[williamdes]

https://github.com/phpmyadmin/phpmyadmin/blob/58c4f3fe16f17400436946be9a82b5811439107b/libraries/classes/InsertEdit.php#L3426

$transformation_plugin = new $class_name(); I think phpstan did start to be confused by that

[MartinMystikJonas]

Hmm yes this is strange why it thinks it could be class-string in the first place.

[ondrejmirtes]

The main problem is that this should be object: https://phpstan.org/r/3d5411f4-9611-48af-abb5-85c24eef9cf4

The rule you're bumping into is that method_exists($mixed, 'foo') casts the first parameter to class-string|object and it's saving you from this scenario: https://3v4l.org/aQoTZ

But in your case the first argument should be object so that class-string will no longer be in play.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@70756b0

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.