Caching edge case when there is missing symbol

[tomasfejfar]

Bug report

PHPStan - PHP Static Analysis Tool 0.12.65 (not the latest, but close I guess)

When there is missing symbol, the cache is not invalidated when the symbol appears elsewhere.

Code snippet that reproduces the problem

(ain't that simple)

• let there be a class MyClass, that uses Guzzle and contains RequestOptions::ALLOW_REDIRECTS somewhere in the code
• you checkout the branch containing the above code and run phpstan
• cache is saved with ~ Access to undefined constant RequestOptions::ALLOW_REDIRECTS. in the file MyClass.php
• you notice that this is caused by missing library and run composer install

Expected output

• now that the symbol is known, there is no error

Actual output

• the cache remains in place (I assume that because the file with the error has not changed) and the violation is reported again
• you need to find out that the cache is the culprit and remove it

Is this expected behavior?

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[tomasfejfar]

Yes, sorry. I don't think it can be reproduced in sandbox with cache :(

[ondrejmirtes]

The result cache is invalidated when composer.lock changes. It doesn't invalidate if something changes in vendor/ without changing the lock file. So if you run PHPStan and only then composer install, the cache currently doesn't get invalidated.

But I looked into it and decided to add the installed versions to metadata too: phpstan/phpstan-src@f11c0f0

Please test dev-master with the workflow above to see if it helps in your use case.

[ondrejmirtes]

Now released in 0.12.72.

[tomasfejfar]

Thanks, will check it!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.