New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMElement::removeAttributeNode error on PHP 8.0 but fine on PHP 7.1 - 7.4 #4268

Closed

eclipxe13 opened this issue Dec 21, 2020 · 3 comments

eclipxe13 commented Dec 21, 2020

PHPStan 0.12 on PHP 8.0 report the error:

Parameter #1 $qualifiedName of method DOMElement::removeAttributeNode() expects string, DOMAttr given.

On PHP 7.1 - 7.4 does not report any error.

Check: https://phpstan.org/r/8d846859-ffc0-48a8-bf6b-b58bcee1baa1

Signature DOMElement::removeAttributeNode(DOMAttr $oldnode): bool is well defined on https://github.com/phpstan/phpstan-src/blob/19bf582aa3c0e0809446a17399d17d17ab40297c/resources/functionMap.php#L1956 since 2018-02-18 commit phpstan/phpstan-src@f486280.

The text was updated successfully, but these errors were encountered:

Member

ondrejmirtes commented Dec 21, 2020

Reported as PHP bug: https://bugs.php.net/bug.php?id=80537

Member

ondrejmirtes commented Dec 21, 2020

Fixed: php/php-src@27e2508 + phpstan/php-8-stubs@4f642d7 + phpstan/phpstan-src@4430549

Thank you very much @nikic for such a swift fix :)

ondrejmirtes closed this as completed

github-actions bot commented May 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.