Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable parameter is not infered to not nullable after conditions checking for null #4215

Closed
MK-42 opened this issue Dec 10, 2020 · 3 comments
Labels

Comments

@MK-42
Copy link

MK-42 commented Dec 10, 2020

Bug report

Conditions that ensure nullable int is not nullable anymore are not respected by phpstan.
The two conditions cancel out the possibility that the nullable int parameter is null.

Code snippet that reproduces the problem

https://phpstan.org/r/b4d84b76-413d-4cab-961a-ba20da3497fd

Expected output

There should be no error detected in the code

@ondrejmirtes ondrejmirtes added this to the Dependent types milestone Dec 11, 2020
@phpstan-bot
Copy link
Contributor

@MK-42 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-16: Parameter #1 $i of function intFunc expects int, int|null given.
+No errors

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@b3548f7

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants