Call to function in_array() with arguments 'integer', array('integer'|'string') and true will always evaluate to true.

[leo108]

Bug report

Please check the code snippet for the detail

Code snippet that reproduces the problem

https://phpstan.org/r/2469d3b4-efd8-4ca3-9d2f-b094ad5159e1

Expected output

Should not have any error.

[leo108]

After some research, I think the issue is here https://github.com/phpstan/phpstan-src/blob/0.12.57/src/Rules/Comparison/ImpossibleCheckTypeHelper.php#L191,

The result type is an UnionType of 'integer'|'string', the $argumentType is a ConstantStringType 'integer', I think the isSuperTypeOf() should return maybe instead of yes

[leo108]

A proposed fix is here leo108/phpstan-src@d07936a, but it breaks many other tests.

[ondrejmirtes]

Looks like the same problem as: #3892

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.