Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to function bcscale() on a separate line has no effect #4029

Closed
simPod opened this issue Oct 31, 2020 · 4 comments
Closed

Call to function bcscale() on a separate line has no effect #4029

simPod opened this issue Oct 31, 2020 · 4 comments

Comments

@simPod
Copy link
Contributor

simPod commented Oct 31, 2020

Call to function bcscale() on a separate line has no effect.

https://phpstan.org/r/40450e78-80f7-4170-a394-86b2c9578e21

which is false positive:

<?php

echo bcsqrt(2);
echo PHP_EOL;
bcscale(15);
echo bcsqrt(2);
1
1.414213562373095
@ondrejmirtes
Copy link
Member

Send a PR to https://github.com/JetBrains/phpstorm-stubs/blob/e8677b2f00659ebd8dde291dcd3a6a81385aae69/bcmath/bcmath.php#L150-L151 that removes the #[Pure] attribute. Thanks.

@simPod
Copy link
Contributor Author

simPod commented Oct 31, 2020

Done, thx JetBrains/phpstorm-stubs#943

@ondrejmirtes
Copy link
Member

Updated the stubs: phpstan/phpstan-src@51aaf57

@github-actions
Copy link

github-actions bot commented May 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @simPod