Some strange NEVER compatibility issue

[b1rdex]

https://phpstan.org/r/cbdc5e54-29b0-486f-9f5b-cac0e4366768

<?php declare(strict_types = 1);

interface foo {
	/**
	 * @return void
	 * @phpstan-return never
	 */
	public function bar();	
}

class bar implements foo {
	public function bar(): void {
		throw new \Exception();	
	}
}

Removing the native void return type fixes the issue.

[ondrejmirtes]

Hi, I fixed the error message: phpstan/phpstan-src@38fe693

Otherwise the reported error seems legit.

[b1rdex]

Hmm, I don't get why it's legit. I thought that PHPDoc types are inherited and it's a bug. Why it isn't possible to declare a native return type besides never? The only option here is to declare a native type on the interface?

[b1rdex]

https://phpstan.org/r/0e134edb-d7fe-4d69-a459-c9ae46423018
Why the error is still present when I add never using PHPDoc?

[ondrejmirtes]

You're hitting the edges of the type system where things are weird :) Usually you'd get this message:

PHPDoc tag @return with type NEVER is incompatible with native type void.

But because it's *NEVER* that's a subtype of every type, this message doesn't show up, but the PHPDoc gets not used anyway, so it's still void in bar vs. never in foo.

For void it's technically valid to have return; in the method body, but for never it's not, so these types aren't exactly interchangeable.

[ondrejmirtes]

I could probably make never + void result in never...

[ondrejmirtes]

Fixed: phpstan/phpstan-src@1857c6c

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.