Bug with isset and !empty in 0.12.51

[murtukov]

Bug report

The simple check with isset() and !empty()stopped to work as expected, when I updated to 0.12.51. It worked without errors from 0.12.33 to 0.12.50. I couldn't reproduce it in the playground.

Code snippet that reproduces the problem

if (isset($description)) {
    echo $description;
}

Expected output

No errors.

Actual output

Undefined variable: $description

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.
It will most likely be closed after manual review.

[ondrejmirtes]

I couldn't reproduce it in the playground.

This doesn't help me solve the problem. Can you show more surrounding code? And is it inside function or in the global scope?

[murtukov]

@ondrejmirtes I've created an empty Symfony project with PHPStan 0.12.51 to reproduce this issue.

https://github.com/murtukov/phpstan-reproduce-issue

Just composer install and vendor/bin/phpstan analyse src

[murtukov]

I am using the extract function to initialize variables, e.g.:

protected function buildConfigLoader(array $config): void
{
    /**
     * @var array       $fields
     * @var string|null $description
     * @var array|null  $interfaces
     * @var string|null $resolveType
     * [...]
     *
     * @phpstan-ignore-next-line
     */
    extract($config);

    $configLoader = Collection::assoc();

    if (isset($description)) {
        $configLoader->addItem('description', $description);
    }

    // ...

This is the line in the real project, where this error occurs:
https://github.com/overblog/GraphQLBundle/blob/master/src/Generator/TypeBuilder.php#L192

[ondrejmirtes]

Reproduction: https://phpstan.org/r/29dec30b-676c-4bb1-91b7-8447ba206f9e

[murtukov]

@ondrejmirtes this reproduction also throws Variable $description in isset() is never defined. which is not present in my case.

[ondrejmirtes]

@murtukov Depends on the level you're running.

[murtukov]

@ondrejmirtes I'm using level 7 in my project, it still doesn't throw Variable $description in isset() is never defined., while in the playground it throws this message on every level, except 0.

So is this a bug (the issue described in the first message)?

[ondrejmirtes]

This is what happens when I run level 5 on your provided example repository:

$ vendor/bin/phpstan analyse -l 5 src
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------
  Line   Controller/IndexController.php
 ------ ----------------------------------------------------
  11     Variable $description in isset() is never defined.
  12     Undefined variable: $description
  16     Undefined variable: $info
 ------ ----------------------------------------------------


 [ERROR] Found 3 errors

The message Variable $description in isset() is never defined. is there.

[murtukov]

@ondrejmirtes you are right, the reason why I didn't get this error in my real project, is that I suppressed it.

But the main issue is still there: 0.12.51 introduces Undefined variable. Is it a bug or intended to be so?

[ondrejmirtes]

Fixed: phpstan/phpstan-src@d3e7b9c

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.