Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isset($notDefined) is not working in foreach #3985

Closed
voku opened this issue Oct 22, 2020 · 5 comments
Closed

isset($notDefined) is not working in foreach #3985

voku opened this issue Oct 22, 2020 · 5 comments

Comments

@voku
Copy link
Contributor

voku commented Oct 22, 2020

Bug report

Undefined variables are not detected inside "isset()" + foreach

Code snippet that reproduces the problem

https://phpstan.org/r/98c8d071-a9a6-496a-a7bd-0d5dbe680441

Expected output

ERROR: UndefinedVariable - 10:14 - Cannot find referenced variable $foo
@dktapps
Copy link
Contributor

dktapps commented Oct 22, 2020

This looks similar to #3782. I'd guess the same problem underlies both issues.

@voku
Copy link
Contributor Author

voku commented Oct 22, 2020

$certainty = $scope->hasVariableType($var->name); in VariableCertaintyInIssetRule is returning 0 (maybe), so it seems to be a bug in "Scope"?

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@3b21093

@ondrejmirtes
Copy link
Member

@dktapps #3782 does not involve isset() so it's not the same bug.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ondrejmirtes @voku @dktapps