Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\SoapServer stub is missing old style constructor with php 7 #3975

Closed
sakarikl opened this issue Oct 20, 2020 · 7 comments
Closed

\SoapServer stub is missing old style constructor with php 7 #3975

sakarikl opened this issue Oct 20, 2020 · 7 comments

Comments

@sakarikl
Copy link

Bug report

phpstan stub for \SoapServer seems to reflect php 8 structure for it. With php 7 will give false positives for a call to a old style cosntructor

https://phpstan.org/r/c3acec73-226d-40f4-8a6c-356ae666a50f

Expected output

expected no errors

@ondrejmirtes
Copy link
Member

@sakarikl
Copy link
Author

It seems to be correct in there.

this worked fine before php 8 support in phpstan

@ondrejmirtes
Copy link
Member

It's not correct in there. Compare SoapClient and SoapServer. One has the old style constructor and the other doesn't.

@sakarikl
Copy link
Author

Just updated from 0.12.48 to 0.12.50 and this error came up.

@ondrejmirtes
Copy link
Member

Because of this change: JetBrains/phpstorm-stubs@f23297f#diff-642148d22d9633b96b4f1007d0831e7eea0148d7fd4fe1ad18bb6086bfd5e2cbR463-R731

The constructors should have been added, not renamed.

@ondrejmirtes
Copy link
Member

Fixed phpstan/phpstan-src@4a886db

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants