Pro mode in docker

[stanislav-janu]

Hi, I'm trying run new PRO in docker, but there is problem and PHPStan writes me a strange bug.

What am I doing wrong?

docker run --rm -p 11111:11111 -v $PWD:/app phpstan/phpstan analyse app --memory-limit=1G --ansi --pro
Note: Using configuration file /app/phpstan.neon.
 352/352 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                
 [ERROR] PHPStan Pro can't be launched because of these errors:                 
                                                                                

                                                                                
 [OK] No errors                                                                 
                                                                                

Please fix them first and then re-run PHPStan.

Thanks.

[stanislav-janu]

phpstan.neon

parameters:
	level: 'max'
	checkMissingIterableValueType: false
	checkGenericClassInNonGenericObjectType: false
	ignoreErrors:
		- '#^Class SoapClient not found\.(.*)$#'
		- '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
		- '#Call to an undefined method [a-zA-Z0-9\\_]+::addReCaptcha\(\)#'
		- '#^Short ternary operator is not allowed\.#'

includes:
	- vendor/phpstan/phpstan-nette/rules.neon
	- vendor/phpstan/phpstan-nette/extension.neon
	- vendor/phpstan/phpstan-strict-rules/rules.neon
	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
	- vendor/thecodingmachine/phpstan-safe-rule/phpstan-safe-rule.neon

[ondrejmirtes]

What do you see when you run PHPStan in Docker without --pro? Does it pass?

[stanislav-janu]

What do you see when you run PHPStan in Docker without --pro? Does it pass?

Without --pro is everything ok.

docker run --rm -p 11111:11111 -v $PWD:/app phpstan/phpstan analyse app --memory-limit=1G --ansi
Note: Using configuration file /app/phpstan.neon.
 352/352 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                
 [OK] No errors                                                                 
                                                                                

[ondrejmirtes]

Hi, can you please pull phpstan/phpstan:nightly image and try it by running --pro -vvv? It should output some debugging messages.

Please note that the phpstan/phpstan:nightly is quite big (as opposed to the stable images) so don't be surprised :)

[ondrejmirtes]

I just made the nightly image much smaller :)

[stanislav-janu]

docker run --rm -p 11111:11111 -v $PWD:/app phpstan/phpstan:nightly analyse app --memory-limit=1G --ansi --pro -vvv
Note: Using configuration file /app/phpstan.neon.
Result cache not used because the cache file does not exist.
 352/352 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 22 secs/22 secs 64.0 MiB


                                                                                
 [ERROR] PHPStan Pro can't be launched because of these errors:                 
                                                                                

                                                                                
 [OK] No errors                                                                 
                                                                                

Please fix them first and then re-run PHPStan.
Result cache was not saved.
Used memory: 64 MB

[ondrejmirtes]

Please try to pull phpstan/phpstan:nightly and run it again, there should be more messages.

[stanislav-janu]

Some error is there, but I expected it after colon.

> docker run --rm -p 11111:11111 -v $PWD:/app phpstan/phpstan:nightly analyse app --memory-limit=1G --ansi --pro -vvv
Note: Using configuration file /app/phpstan.neon.
Result cache not used because the cache file does not exist.
 352/352 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 20 secs/20 secs 64.0 MiB

Result cache was not saved because of non-ignorable exception.

                                                                                
 [ERROR] PHPStan Pro can't be launched because of these errors:                 
                                                                                

                                                                                
 [OK] No errors                                                                 
                                                                                

Please fix them first and then re-run PHPStan.
Result cache was not saved.
Used memory: 64 MB
Script docker run --rm -p 11111:11111 -v $PWD:/app phpstan/phpstan:nightly analyse app --memory-limit=1G --ansi --pro -vvv handling the sa event returned with error code 1

[ondrejmirtes]

Oh, I think I figured it out (phpstan/phpstan-src@2af17d9). You should now see that some error you're ignoring is actually non-ignorable and you should fix it instead. It's probably going to be the SoapClient one.

Once you fix this error, you'll be able to run PHPStan Pro as well :)

Let me know how it works for you, thanks.

[stanislav-janu]

Everything is ok if I use standard command vendor/bin/phpstan.phar analyse app --ansi --pro. There I can install extensions to php.

But in Docker I can not. I would have to make another Dockerfile with command docker-php-ext-install soap.

Thank you so much Ondřej for your help!

[ondrejmirtes]

Interesting, since the static reflection (https://phpstan.org/blog/zero-config-analysis-with-static-reflection) it shouldn't be necessary to install PHP extensions. Can you share the piece of code that crashes without the extension installed? Thank you!

[stanislav-janu]

 ------ -------------------------------------------------------------------- 
  Line   model/Google/Ads/Manager.php                                        
 ------ -------------------------------------------------------------------- 
         Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  30     Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  39     Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  40     Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  160    Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
  160    Class SoapClient not found.                                         
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ -------------------------------------------------------------------- 

On line 30 is use Google\AdsApi\AdWords\v201809\cm\CampaignService;
There is implemented googleads/googleads-php-lib package.

This starts on line 152

	public function getGoogleAdsDistinctCampaigns(AdWordsSession $session): ?array
	{
		$campaigns = [];

		try {
			$adWordsServices = new AdWordsServices();

			/** @var CampaignService $campaignService */
			$campaignService = $adWordsServices->get($session, CampaignService::class);
...

Line 160 is $campaignService = $adWordsServices->get($session, CampaignService::class);

[hopeseekr]

My PHPExpertsInc/docker-phpstan project supports –pro…

I believe in supporting this project so much that I made sure of it as soon as --pro was released!!

I am not sure why there is such hostility with other PHP projects to me dockerizing their stacks to make them independent of even having PHP installed on the system, but… all you ahve to do install PHPStan with my system is this:

composer require phpexperts/docker-phpstan

That’s it! Done!

You can do this IN PHP 5.3, if you want, and it will JUST WORK (!!)

This is by far and away the easiest way to get phpstan on eveyr single project, no matter if you even have php on your system or not.

If you want to test your app on PHP 8.0?

composer require phpexperts/dockerize-php8

DONE! Now everything in your local PWD will be executed using PHP v8.0 beta 4!

phpexperts/docker-phpstan:

• Doesn’t pollute your vendor deps.
• Independent of any system/project PHP (runs 7.4)
• Super fast to install: composer require –dev phpexperts/docker-phpstan
• Integrates great with Travis-CI!

30 second installation demo: https://youtu.be/rpby2nz2iEI

OR just do:

wget https://raw.githubusercontent.com/PHPExpertsInc/docker-phpstan/master/bin/phpstan
sudo mv phpstan /usr/local/bin

[hopeseekr]

The maintainer of this project is totally encouraged to fork phpexpertsinc/docker-phpstan and integrate it into their own project.

Doing composer require --dev phpstan/docker-phpstan and having it load regardless of PHP or project-specific dependency issues is -amazing-!! Esp on PHP 8 and PHP 7.1 and below that PHPStan doesn’t natively support!!

This is how I have analyzed 100,000+ packagist.org projects using phpstan via my Bettergist Collective project!!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.