feature request: make sure an exception is used

[enumag]

Feature request

In my code I'm using some static exception factory methods similar to Doctrine's ORMException. For instance:

Today I found out that in some cases my code only called the method but did nothing with the returned exception - the throw statement was missing.

I'd like PHPStan to tell me about these "unused exception" cases.

[ondrejmirtes]

I'm not sure what you exactly mean without a code sample but I'd guess this package does what you want: https://github.com/pepakriz/phpstan-exception-rules/

[ondrejmirtes]

I'd guess it can be generalized into "Calling a method that doesn't have a side effect - report when the returned value isn't used".

[enumag]

I'm not sure what you exactly mean without a code sample but I'd guess this package does what you want: pepakriz/phpstan-exception-rules

No, I don't think so.

I'd guess it can be generalized into "Calling a method that doesn't have a side effect - report when the returned value isn't used".

Yup, agreed. 👍

[ondrejmirtes]

This now works, but the method returning the exception must be tagged with @phpstan-pure: https://phpstan.org/r/feaca926-456c-40b8-96d5-a9c37eac6c99

Implemented in: phpstan/phpstan-src#412

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.