Unset detection with try/catch does not take into account origin of the exception.

[frankdejonge]

Bug report

When an unset call is placed after a call where an exception can originate from, the catch clause is not able to use the variable, even though the unset call can never be made.

Code snippet that reproduces the problem

https://phpstan.org/r/abf2e5c9-90a3-40fc-9979-6d19255e7c67

Expected output

No errors were found

[ondrejmirtes]

This is very similar to other issues grouped in this milestone: https://github.com/phpstan/phpstan/milestone/11

[phpstan-bot]

@frankdejonge PHPStan now reports different result with your code snippet:

@@ @@
+PHP 7.3 – 8.0 (1 error)
+==========
+
+31: Variable $body might not be defined.
+
+PHP 7.1 – 7.2 (2 errors)
+==========
+
+30: Caught class JsonException not found.
 31: Variable $body might not be defined.

Full report

PHP 7.3 – 8.0 (1 error)

Line	Error
31	Variable $body might not be defined.

PHP 7.1 – 7.2 (2 errors)

Line	Error
30	Variable $body might not be defined.
31	Variable $body might not be defined.

[phpstan-bot]

@frankdejonge After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-31: Variable $body might not be defined.
+PHP 7.3 – 8.0
+==========
+
+No errors
+
+PHP 7.1 – 7.2 (1 error)
+==========
+
+30: Caught class JsonException not found.

Full report

PHP 7.3 – 8.0

No errors

PHP 7.1 – 7.2 (1 error)

Line	Error
30	Caught class JsonException not found.

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#481

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.