Caught class ParseError is not an exception

[b1rdex]

https://phpstan.org/r/fdea8bde-f77f-4362-b49c-9055a2de728f

I'm not sure why but PhpStan reports catching ParseError on php < 7.3

[JanTvrdik]

Maybe related

ParseError extends CompileError as of PHP 7.3.0. Formerly, it extended Error.

[ondrejmirtes]

Yes, this is because ParseError stub looks like this:

class ParseError extends CompileError {

}

Because CompileError isn't available in PHP < 7.3, to prevent errors this code in PhpStormStubsSourceStubber modifies the stub to this:

class ParseError {

}

Of course it should change the extends to Error and not just remove it. I'll fix it.

[ondrejmirtes]

Fixed: ondrejmirtes/BetterReflection@bda4316 + phpstan/phpstan-src@353cb01

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.