Inline yield in Generator complains about missing return type

[dantleech]

PHPStan reports a false positive when inline yield is used:

<?php

function foo(): Generator
{
    while ($bar = yield 'foo') {
    }
}

Function foo() should return Generator but return statement is missing.

https://phpstan.org/r/ec37ffcb-25f5-424a-b21c-2f5ec10703dd

[ondrejmirtes]

This one is really easy to fix. We have to also take into account $condResult->hasYield() here https://github.com/phpstan/phpstan-src/blob/a23f80828620e663c67bbacdcb246b888db158a4/src/Analyser/NodeScopeResolver.php#L809, not just $finalScopeResult->hasYield() at https://github.com/phpstan/phpstan-src/blob/a23f80828620e663c67bbacdcb246b888db158a4/src/Analyser/NodeScopeResolver.php#L870.

The best way to test this is to add another test to Functions ReturnTypeRuleTest.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.