Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive private function __clone() is unused #3630

Closed
b1rdex opened this issue Jul 20, 2020 · 2 comments
Closed

False positive private function __clone() is unused #3630

b1rdex opened this issue Jul 20, 2020 · 2 comments

Comments

@b1rdex
Copy link
Contributor

b1rdex commented Jul 20, 2020 •
edited

https://phpstan.org/r/b8b34edb-7d22-4477-a1a7-4aa532d81c24

This is a pretty common way to forbid cloning the object in PHP: https://github.com/search?q=%22private+function+__clone%28%29%22&type=Code

IMO this shouldn't be reported as unused. It's like private function __construct() in singletons.
@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@cdbed86

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @b1rdex