Non-literal parameter default parsing incorrectly adding NULL to parameter types

[dktapps]

Bug report

Code snippet that reproduces the problem

A new issue cropped up since you updated the stubs that I can't make sense of, other than perhaps PHPStan is incorrectly parsing the $options default from the stubs: https://phpstan.org/r/eb28e725-c7ba-4f56-9dde-fe948c3f2d56

Since there's nowhere that says that this accepts null (not native reflection, and not stubs either, I cross-checked this everywhereI could think of to try and figure out where the null was coming from), it's my belief that PHPStan is incorrectly interpreting the default value to be NULL and therefore showing this problem.

Expected output

No error.

[dktapps]

Changing the default in the phpstorm stubs to a literal (f.e. 0) makes the problem go away, so it's definitely something to do with the default value parsing.

[ADmad]

Similar incorrect error seen here too https://github.com/cakephp/cakephp/pull/14812/files#file-src-collection-collectiontrait-php-L192

[ondrejmirtes]

@ADmad This doesn’t tell me the error, can you show me what conflicting method is there and how the error looks like?

[ADmad]

@ondrejmirtes If you are using a desktop browser that link should scroll the page to the exact location where error message is shown.

Parameter #2 $type (int) of method Cake\Collection\Collection::max() is not compatible with parameter #2 $type (int|null) of method Cake\Collection\CollectionInterface::max().

Methods in question:

https://github.com/cakephp/cakephp/blob/47912247fa64dc35066c8fe74d24bee38480d4b6/src/Collection/CollectionTrait.php#L192

https://github.com/cakephp/cakephp/blob/47912247fa64dc35066c8fe74d24bee38480d4b6/src/Collection/CollectionInterface.php#L263

[ADmad]

Sorry, it seems the links behaves differently for those who don't have commit access to the repo.

[drupol]

@ADmad This doesn’t tell me the error, can you show me what conflicting method is there and how the error looks like?

Dear @ondrejmirtes, does this helps you ? https://phpstan.org/r/ffbb5a78-a8b2-46d9-9f45-aa264ed74d94

[ondrejmirtes]

Fixed: ondrejmirtes/BetterReflection@c04a2c8 + phpstan/phpstan-src@d3044ee

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.