try/catch improvement idea

[gnutix]

Everything being inferred after the last possible piece of code that may throw an exception should not have an impact on the catch clause.

Examples :
Correct : https://phpstan.org/r/c33d8ed6-a27a-447c-b8ee-c4d842ee2354
Incorrect : https://phpstan.org/r/3cdc98ed-2e4f-4269-8197-bd1dfaa7ecd2

[ondrejmirtes]

Yeah, there's a milestone for issues like this: https://github.com/phpstan/phpstan/milestone/11

[phpstan-bot]

@gnutix PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.0 (1 error)
+==========
+
+7: Parameter #1 $string of function strtolower expects string, int|string given.
+
+PHP 7.1 – 7.4 (1 error)
+==========
+
 7: Parameter #1 $str of function strtolower expects string, int|string given.

Full report

PHP 8.0 (1 error)

Line	Error
7	`Parameter #1 $string of function strtolower expects string, int

PHP 7.1 – 7.4 (1 error)

Line	Error
7	`Parameter #1 $str of function strtolower expects string, int

[phpstan-bot]

@gnutix PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.0 (1 error)
+==========
+
+6: Parameter #1 $string of function strtolower expects string, int|string given.
+
+PHP 7.1 – 7.4 (1 error)
+==========
+
 6: Parameter #1 $str of function strtolower expects string, int|string given.

Full report

PHP 8.0 (1 error)

Line	Error
6	`Parameter #1 $string of function strtolower expects string, int

PHP 7.1 – 7.4 (1 error)

Line	Error
6	`Parameter #1 $str of function strtolower expects string, int

[phpstan-bot]

@gnutix After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-7: Parameter #1 $str of function strtolower expects string, int|string given.
+PHP 8.0 (1 error)
+==========
+
+7: Parameter #1 $string of function strtolower expects string, int given.
+
+PHP 7.1 – 7.4 (1 error)
+==========
+
+7: Parameter #1 $str of function strtolower expects string, int given.

Full report

PHP 8.0 (1 error)

Line	Error
7	Parameter #1 $string of function strtolower expects string, int given.

PHP 7.1 – 7.4 (1 error)

Line	Error
7	Parameter #1 $str of function strtolower expects string, int given.

[phpstan-bot]

@gnutix After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-6: Parameter #1 $str of function strtolower expects string, int|string given.
+No errors

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#481

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.