0.12.26 - has no return typehint specified with a phpdoc block

[williamdes]

 ------ ----------------------------------------------------------------------- 
  Line   libraries/classes/Plugins/ExportPlugin.php                             
 ------ ----------------------------------------------------------------------- 
  126    Method PhpMyAdmin\Plugins\ExportPlugin::exportRoutines() has no        
         return typehint specified.                                             
  126    Method PhpMyAdmin\Plugins\ExportPlugin::exportRoutines() has           
         parameter $db with no typehint specified.                              
  288    Method PhpMyAdmin\Plugins\ExportPlugin::initAlias() has no return      
         typehint specified.                                                    
  288    Method PhpMyAdmin\Plugins\ExportPlugin::initAlias() has parameter      
         $aliases with no typehint specified.                                   
  288    Method PhpMyAdmin\Plugins\ExportPlugin::initAlias() has parameter $db  
         with no typehint specified.                                            
  288    Method PhpMyAdmin\Plugins\ExportPlugin::initAlias() has parameter      
         $table with no typehint specified.                                     
 ------ ----------------------------------------------------------------------- 
 ------ ----------------------------------------------------------------------- 
  Line   libraries/classes/Transformations.php                                  
 ------ ----------------------------------------------------------------------- 
  476    Method PhpMyAdmin\Transformations::clear() has no return typehint      
         specified.                                                             
  476    Method PhpMyAdmin\Transformations::clear() has parameter $column with  
         no typehint specified.                                                 
  476    Method PhpMyAdmin\Transformations::clear() has parameter $db with no   
         typehint specified.                                                    
  476    Method PhpMyAdmin\Transformations::clear() has parameter $table with   
         no typehint specified.                                                 
 ------ ----------------------------------------------------------------------- 

Refs:

• https://github.com/phpmyadmin/phpmyadmin/blob/5d933e03b96138826d305baee0c076826404d43b/libraries/classes/Plugins/ExportPlugin.php#L126
• https://github.com/phpmyadmin/phpmyadmin/blob/5d933e03b96138826d305baee0c076826404d43b/libraries/classes/Plugins/ExportPlugin.php#L288
• https://github.com/phpmyadmin/phpmyadmin/blob/5d933e03b96138826d305baee0c076826404d43b/libraries/classes/Transformations.php#L476

Version: 0.12.26

For me this is a regression 🤔

PS: thank you for the "You're using a deprecated config option bootstrap" I would never noticed other ways.

cc @ondrejmirtes

[ondrejmirtes]

Does it happen only in those two files? Any idea what could cause it? What's special about them?

[williamdes]

Only this 2 files came out after the upgrade.

Nothing special, I do not understand why there is something triggered.
One is abstract and the other one is nothing more than a regular class

One common pattern is that they all have an optional parameter

[williamdes]

👏 for the blog post and for your awesome work !

[b1rdex]

I've got the same problem but for a class property. I assume that's because there is another docblock before the method/property docblock. Mine example with the same problem:

class Z {
/** @see Zzz */
/** @var int */
public $property;
}

The problem is gone if you remove the /** @see Zzz */ comment.

It looks like all 3 examples provided @williamdes has the same – there is another docblock before the dockblock with the problem.

[adaamz]

Strange, but why to have 2 phpdocs for one property/method?
In that phpMyAdmin code i see there is used phpdoc but it should be probably only block comment.

[williamdes]

Strange, but why to have 2 phpdocs for one property/method?
In that phpMyAdmin code i see there is used phpdoc but it should be probably only block comment.

Maybe for historical reasons, maybe to add some context for plugin integrators

[ondrejmirtes]

Fixed: ondrejmirtes/BetterReflection@ab41f90 + phpstan/phpstan-src@98cdb30

[williamdes]

Fix confirmed by phpmyadmin/phpmyadmin@d9a8e22
💪 👏

[ondrejmirtes]

Awesome :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.