False positive when 10 conditions are joined by '||' in if.

[tekezo]

Bug report

The following error is reported if 10 conditions are joined by '||' in if.

Strict comparison using === between *NEVER* and 'XXX' will always evaluate to false.

Code snippet that reproduces the problem

https://phpstan.org/r/4d8f632c-d4fc-4cc6-b9e2-ae81db46b548

There are no problem until 9 conditions.
https://phpstan.org/r/0f595079-d3a0-4fd1-aa2a-af28d9068fda

[xPaw]

Happened in my code base too.

https://phpstan.org/r/a87dab63-efd1-4783-8c85-89ed46b630fc

[phpstan-bot]

@tekezo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Strict comparison using === between *NEVER* and '0' will always evaluate to false.
+No errors

[phpstan-bot]

@xPaw After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Strict comparison using === between *NEVER* and 'j' will always evaluate to false.
-15: Strict comparison using === between *NEVER* and 'k' will always evaluate to false.
-16: Strict comparison using === between *NEVER* and 'l' will always evaluate to false.
-17: Strict comparison using === between *NEVER* and 'm' will always evaluate to false.
-18: Strict comparison using === between *NEVER* and 'o' will always evaluate to false.
-19: Strict comparison using === between *NEVER* and 'p' will always evaluate to false.
+No errors

[tekezo]

Thanks!

[ondrejmirtes]

This isn't fully fixed, you can still break it by introducing an empty string into the mix: https://phpstan.org/r/d98133e1-9091-4c05-9126-4951aeef8a63

[phpstan-bot]

@ondrejmirtes After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Strict comparison using === between *NEVER* and '0' will always evaluate to false.
+No errors

[ondrejmirtes]

I managed to solve this.

• Removed CONSTANT_SCALAR_UNION_THRESHOLD: phpstan/phpstan-src@c56d866
• Optimization of TypeCombinator::union() when a lot of scalars are involved: phpstan/phpstan-src@da9e061

Look forward to the next release (0.12.95) :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.