Looping through an array shape has wrong count

[allejo]

Bug report

Given I'm using an array shape like array{bool, bool, bool}, it expects a key of int<min, 2>, where I would think it should be int<min, 3> or make it inclusive?

Code snippet that reproduces the problem

https://phpstan.org/r/eaaf2943-60db-49fa-9336-a2dead66c788

<?php declare(strict_types = 1);

class HelloWorld
{
	/** @var array{bool, bool, bool} */
	private $tuple;
	
	public function main(): void
	{
		$this->tuple = [true, true, true];
		
		for ($i = 0; $i < 3; ++$i)
		{
		    $this->tuple[$i] = false;
		}
	}
}

Expected output

I would think PHPStan should accept this code as valid.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+14: Array (array(bool, bool, bool)) does not accept key int<min, 2>.

Full report

Line	Error
14	Array (array(bool, bool, bool)) does not accept key int<min, 2>.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+14: Array (array{bool, bool, bool}) does not accept key int<min, 2>.

Full report

Line	Error
14	Array (array{bool, bool, bool}) does not accept key int<min, 2>.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+ 6: Property HelloWorld::$tuple is never read, only written.
+14: Array (array{bool, bool, bool}) does not accept key int<min, 2>.

Full report

Line	Error
6	Property HelloWorld::$tuple is never read, only written.
14	Array (array{bool, bool, bool}) does not accept key int<min, 2>.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+ 6: Property HelloWorld::$tuple is never read, only written.
+14: Property HelloWorld::$tuple (array{bool, bool, bool}) does not accept non-empty-array<int<min, 2>, false>.

Full report

Line	Error
6	Property HelloWorld::$tuple is never read, only written.
14	Property HelloWorld::$tuple (array{bool, bool, bool}) does not accept non-empty-array<int<min, 2>, false>.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+ 6: Property HelloWorld::$tuple is never read, only written.
+14: Property HelloWorld::$tuple (array{bool, bool, bool}) does not accept non-empty-array<int<0, 2>, false>.

Full report

Line	Error
6	Property HelloWorld::$tuple is never read, only written.
14	Property HelloWorld::$tuple (array{bool, bool, bool}) does not accept non-empty-array<int<0, 2>, false>.

[phpstan-bot]

@allejo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: Array (array<int, bool>) does not accept key int<min, 2>.
+ 6: Property HelloWorld::$tuple is never read, only written.

Full report

Line	Error
6	Property HelloWorld::$tuple is never read, only written.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@3b5fd94

[allejo]

Thank you for the fix! 🥳

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.