Null Coalescing Operator with objects' attributes

[ThibaudDauce]

Bug report

https://phpstan.org/r/d7f7272b-92ac-4497-a6b2-07c98e3df70e

<?php declare(strict_types = 1);

$test = random_int(0, 10);

if ($test > 5) {
	$user = new stdClass;
	$user->name = 'Thibaud';
}

echo $user->name ?? 'Default'; // Variable $user might not be defined.

Expected output

There is no error in this code, PHP isset is working with nested attributes isset($abc->def->ghi) (https://www.php.net/manual/fr/function.isset.php#86313) and $var ?? $default is only a shortcut to isset($var) ? $var : $default.

[EdgarSedov]

No info about this yet?(

I'm not familiar with phpstan src at all, but if u'll point me in right direction, i can try to make PR

[ThibaudDauce]

@ondrejmirtes Is it possible to point us in the right direction, I'm happy to make a PR too to fix this bug.

[ondrejmirtes]

@ThibaudDauce I guess that $scope->isInExpressionAssign(new Variable('user')) also has to return true on line 10 which isn't the case right now.

It should be fixed somewhere around NodeScopeResolver::ensureShallowNonNullability / ensureNonNullability. And tested as a new testcase called testBug3283 in DefinedVariableRuleTest.

[brandonkelly]

Running into this as well for @craftcms, on the following lines among others:

• https://github.com/craftcms/cms/blob/a757cdb913a225f20c0f753e3bbdf25d30028cf7/src/controllers/FieldsController.php#L320
• https://github.com/craftcms/cms/blob/a757cdb913a225f20c0f753e3bbdf25d30028cf7/src/controllers/VolumesController.php#L179-L180

[ondrejmirtes]

I figured out what I want to do here:

1. Unify isset() and ?? behaviour, but on the strict side - unknown properties should be reported.
2. Require adding classes with these properties to universalObjectCrateClasses, or require adding @property PHPDoc with those properties above the class.

Currently to suppress the error you can do 2) and should be fine.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@7ddfa17 (my previous comment is about something else which I want to change but it's unrelated to this bugfix)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.