PHPStan mistakenly assumes that an array can pass the is_numeric() test

[morozov]

Bug report

According to the documentation, is_numeric() finds whether a variable is a number or a numeric string. Although, PHPStan thinks that a variable that passes the is-numeric test can contain an array.

Code snippet that reproduces the problem

https://phpstan.org/r/d65e6a61-95bd-44ac-8093-5afe354bf16c

Expected output

No error

[Jean85]

I got the same issue, I attempted a solution with phpstan/phpstan-src#177.

[szepeviktor]

Another test https://phpstan.org/r/29c215da-f552-4d7e-b225-251f923d80bb

@ondrejmirtes Could you start me up how to fix is_numeric handling?

[ondrejmirtes]

@szepeviktor This condition is wrong: https://github.com/phpstan/phpstan-src/blob/06328652b164ec2834d3e5150ee341b335dc6178/src/Type/Php/IsNumericFunctionTypeSpecifyingExtension.php#L38-L40

[ondrejmirtes]

I also wrote some tips here: phpstan/phpstan-src#177 (comment)

[szepeviktor]

@ossinkine Now that you are fluent in PHPStan :) Could you help me in fixing is_numeric handling?

[ondrejmirtes]

Fixed: phpstan/phpstan-src@7f04f75

[morozov]

The issue is also not reproducible on the code where it was originally discovered and suppressed (doctrine/dbal#3799).

Thanks, @ondrejmirtes!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.