New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "isset() always exists and is not nullable" in a try catch finally block #3004

Closed

ls-apaar-mann opened this issue Feb 18, 2020 · 4 comments

Labels

bug

Milestone

NodeScopeResolver...

ls-apaar-mann commented Feb 18, 2020 •

edited

Bug report

Code snippet that reproduces the problem

https://phpstan.org/r/8dd43f1e-0209-471b-bf39-895be1b1a9b5

Expected output

No error.

ondrejmirtes mentioned this issue

PHPStan assumes function/method returns value even if it can throw an exception #3710

Closed

ondrejmirtes added the bug label

ondrejmirtes added this to the NodeScopeResolver bugs milestone

eigan commented Sep 17, 2020

Duplicate of #778

Contributor

phpstan-bot commented Mar 27, 2021

@ls-apaar-mann After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-12: Variable $a in isset() always exists and is not nullable.
+No errors

Member

ondrejmirtes commented Mar 27, 2021

Fixed by: phpstan/phpstan-src#481

ondrejmirtes closed this as completed

ondrejmirtes added a commit to phpstan/phpstan-src that referenced this issue


          Regression tests for precise exception tracking

083cb40

Closes phpstan/phpstan#1597
Closes phpstan/phpstan#3617
Closes phpstan/phpstan#778
Closes phpstan/phpstan#2969
Closes phpstan/phpstan#3004
Closes phpstan/phpstan#3710
Closes phpstan/phpstan#3822
Closes phpstan/phpstan#505
Closes phpstan/phpstan#1670
Closes phpstan/phpstan#1219

github-actions bot commented Apr 29, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.