try-finally false positive

[Firtzberg]

Bug report

I have a try finally block. I want to make sure resources are cleaned up no matter what. I use a simple flag to keep track if the resource was consumed.

Code snippet that reproduces the problem

https://phpstan.org/r/d716d2ac-adc4-4f4a-bdc7-2576859f90ee

Expected output

The static analysis should not claim that the boolean expression at line 22 is always false.

[ondrejmirtes]

Thanks. Right now you can work around it like this: https://phpstan.org/r/da18cec8-7577-4d42-b03b-8697da96438e

[e1himself]

I have the same issue in my code.

https://phpstan.org/r/bc3e6e26-dae9-4909-ba42-653c57618def

[phpstan-bot]

@Firtzberg After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-22: Negated boolean expression is always false.
+No errors

[phpstan-bot]

@e1himself After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-16: Variable $success in isset() always exists and is not nullable.
+No errors

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#481

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.