PHPStan doesn't detect variables in nested loop which will surely be initialized

[paljinov]

PHPStan doesn't detect variables in nested loop which will surely be initialized.

Version being used:
PHPStan - PHP Static Analysis Tool 0.12.3

Code snippet that reproduces the problem

<?php

for ($i = 1; $i < 2; $i++) {
    for ($j = 1; $j < 2; $j++) {
    }
}

echo $i * $j;

Output

+------------------------------------------+
| Line | test.php                          |
+------------------------------------------+
| 8    | Variable $j might not be defined. |
+------------------------------------------+

 [ERROR] Found 1 error 

Expected output

 [OK] No errors

[muglug]

I just implemented this in Psalm – you could presumably PR something similar for PHPStan, though it may require #2806 to be fixed.

[ondrejmirtes]

This is the place that needs fixing in PHPStan: https://github.com/phpstan/phpstan-src/blob/master/src/Analyser/NodeScopeResolver.php#L781-L846

The while loop handling already looks at the condition so it knows when it iterates at least once: https://github.com/phpstan/phpstan-src/blob/master/src/Analyser/NodeScopeResolver.php#L701-L702

[ondrejmirtes]

This one is already fixed.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.