False positive "If condition is always false." when using variable function

[phrounz]

Version used: PHPStan 0.11.8

Offending code

More precisely, the following piece of code:

$rollback_tr = false;
$result = $function($rollback_tr); // $function takes an argument by reference
if ($rollback_tr) {

Expected output:
No errors

Output:
If condition is always false.

[phpstan-bot]

@phrounz PHPStan now reports different result with your code snippet:

@@ @@
-10: If condition is always false.
+10: If condition is always false.
+16: Function myFunction() has no return typehint specified.
+16: Function myFunction() has parameter $rollback_tr with no typehint specified.

Full report

Line	Error
10	Function myFunction() has parameter $rollback_tr with no typehint specified.
16	Function myFunction() has parameter $rollback_tr with no typehint specified.
16	Function myFunction() has parameter $rollback_tr with no typehint specified.

[phpstan-bot]

@phrounz After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-10: If condition is always false.
+16: Function myFunction() has no return typehint specified.
+16: Function myFunction() has parameter $rollback_tr with no typehint specified.

Full report

Line	Error
16	Function myFunction() has no return typehint specified.
16	Function myFunction() has parameter $rollback_tr with no typehint specified.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@109bf99

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.