Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable might not be defined #1801

Closed
danielspk opened this issue Jan 17, 2019 · 4 comments
Closed

Variable might not be defined #1801

danielspk opened this issue Jan 17, 2019 · 4 comments

Comments

@danielspk
Copy link

Summary of a problem or a feature request

PHPStan reports incorrect "Variable $request might not be defined" warning. See the demo: https://phpstan.org/r/dd86ad8a-ffd3-4c6c-84f2-dc72189c973d

Code snippet that reproduces the problem

https://phpstan.org/r/dd86ad8a-ffd3-4c6c-84f2-dc72189c973d

Expected output

This error should not be reported since Throwable should define the variable $response in case of error.

@ondrejmirtes
Copy link
Member

Yeah, PHPStan does not yet track exceptions this way.

@adaamz
Copy link
Contributor

adaamz commented Jul 13, 2019

Looks like this is fixed https://phpstan.org/r/eb04da0b-4544-453e-b2cd-428213e56282

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Jul 13, 2019 via email

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants