Missing report on potential null property when using a dynamic child property

[dbu]

Summary of a problem or a feature request

We do get a warning for the line with explicit field name in the map, but no warning when a property of a nullable property is accessed with a dynamic name.

Code snippet that reproduces the problem

class Product
{
   /**
    * @var MyMap|null
    */
   public $map;
}

class MyMap
{
    public const FIELDS = ['a', 'b'];

    public $a;

    public $b;
}

$product = new Product();
foreach (MyMap::FIELDS as $field) {
    // $product->map can be null, but we get **no** warning from phpstan
    print($product->map->$field);
}

// $product->map can be null and we do get a warning from phpstan
print($product->map->a);

Expected output

Warning that $product->map->$field could be null because Product::$map is nullable.

[ondrejmirtes]

Please attach phpstan.org link as stated in the instructions.

On Thu, 11 Oct 2018 at 12:16, David Buchmann ***@***.***> wrote: Summary of a problem or a feature request We do get a warning for the line with explicit field name in the map, but no warning when a property of a nullable property is accessed with a dynamic name. Code snippet that reproduces the problem class Product{ /** * @var MyMap|null */ public $map;}class MyMap{ public const FIELDS = ['a', 'b']; public $a; public $b;}$product = new Product();foreach (MyMap::FIELDS as $field) { print($product->map->$field);}print($product->map->a); Expected output Warning that $product->map->$field could be null because Product::$map is nullable. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1499>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuMX9ErJzooPTJblTtWRaSbKY8DwCks5ujxqDgaJpZM4XXOej> .

-- Ondřej Mirtes

[dbu]

sorry, missed that. here you go: https://phpstan.org/r/d9a1196f5eea4480f3a33c48547b71f1

[ondrejmirtes]

This already works thanks to phpstan/phpstan-src#348.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.