Invalid argument supplied when condition is stored in variable

[simPod]

	/**
	 * @param mixed[]|string $value
	 */
	public function sayHello($value): void
	{
		$isArray = is_array($value);
		if($isArray){
			foreach($value as $x){
				
			}
		}

	}

Argument of an invalid type array|string supplied for foreach, only iterables are supported.

https://phpstan.org/r/a2c25c03288fbfc18c7d0a7cb6460764

[JanTvrdik]

This is currently expected behavior. Supporting this would require for the static analyzer to prove that the previously computed type guards have not been invalidated at point where they are used, i.e. sth like

$isArray = is_array($value);
$value = 123;
if ($isArray) {
	foreach($value as $x) {
	}
}

[simPod]

makes sense, thx

[ondrejmirtes]

Yes, I call this feature “conditional types” or “dependent types”. “If something is true, then some other thing will be of this type, or some variable will exist etc...”.

On Thu, 12 Jul 2018 at 13:46, Šimon Podlipský ***@***.***> wrote: makes sense, thx — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1209 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuEwuwduGW7feWUmah3rq7HPQs8Gjks5uFzcfgaJpZM4VL5qC> .

-- Ondřej Mirtes

[ondrejmirtes]

Fixed by: phpstan/phpstan-src@a9d5c8b

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.