Exclude second InstalledVersions.php from analysis

[niklasnatter]

Hello,
I am using the symfony/phpunit-bridge package in combination with the sentry/sentry-symfony package in my project.
To prevent error because of missing PHPUnit classes I added the following config to my phpstan.neon:

parameters:
    bootstrapFiles:
        - bin/.phpunit/phpunit-8.5-0/vendor/autoload.php

Unfortunately, I am running into the following error when executing phpstan now:

 ------ -------------------------------------------------------------- 
  Line   src/Security/LoginFormAuthenticator.php                       
 ------ -------------------------------------------------------------- 
         Internal error: Package "sentry/sentry" is not installed      
         Run PHPStan with --debug option and post the stack trace to:  
         https://github.com/phpstan/phpstan/issues/new                 
 ------ -------------------------------------------------------------- 

I already investigated the error a bit and found the following related issues:

• Issue with phpunit 9.4 #4022
• Reproducer for #4022 #4047
• Internal error: Package ocramius/proxy-manager is not installed in file #3949
• It doesn't work with composer 2 getsentry/sentry-symfony#383

As far as I understand, the error happens because phpstan will analyze the bin/.phpunit/phpunit-8.5-0/vendor/composer/InstalledVersions.php file which will overwrite the vendor/composer/InstalledVersions.php file in my project.

The error disappears if i remove the bin/.phpunit/phpunit-8.5-0/vendor/composer/InstalledVersions.php file before executing phpstan, but I am afraid this will break other functionality. Is it somehow possible to tell phpstan to ignore/not read the bin/.phpunit/phpunit-8.5-0/vendor/composer/InstalledVersions.php file?

Unfortunately, the following configuration does not do this for me:

parameters:
    excludePaths:
        - bin/.phpunit/phpunit-8.5-0/vendor/composer/InstalledVersions.php

Thanks in advance for your time!

[ondrejmirtes]

Looks like you should be able to fix this by upgrading your Symfony version: symfony/symfony#39017

At least that's what helper @ossinkine here: #4047 (comment)

[niklasnatter]

Thanks a lot for the fast response! The project uses Symfony 5.2.1 which shout be the most recent version:

> composer info symfony/framework-bundle              

name     : symfony/framework-bundle
descrip. : Symfony FrameworkBundle
keywords : 
versions : * v5.2.1
type     : symfony-bundle
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage : https://symfony.com
source   : [git] https://github.com/symfony/framework-bundle.git 0663407ca5ad12e2e3fe657b32266904b3dc1e3f
dist     : [zip] https://api.github.com/repos/symfony/framework-bundle/zipball/0663407ca5ad12e2e3fe657b32266904b3dc1e3f 0663407ca5ad12e2e3fe657b32266904b3dc1e3f
path     : /Users/niklas/Development/projects/sulu-website/vendor/symfony/framework-bundle
names    : symfony/framework-bundle

I suspect that symfony/symfony#39017 solved this only for the symfony/proxy-manager-bridge package, but not the symfony/phpunit-bridge package 😕

I am aware that the root cause of this cannot be fixed by phpstan. But maybe its possible to configure phpstan to somehow ignore the second InstalledVersions.php file?

[niklasnatter]

Yes, that would be great. Unfortunately I dont know the symfony/phpunit-bridge well enough to do that. I am aware that this is not an issue of phpstan 🙂

But maybe its possible to configure phpstan to somehow ignore the second InstalledVersions.php file?

[niklasnatter]

It looks like I am able to tell phpstan to use the vendor/composer/InstalledVersions.php instead of the bin/.phpunit/phpunit-8.5-0/vendor/composer/InstalledVersions.php by adding it to the bootstrapFiles:

parameters:
    bootstrapFiles:
        - bin/.phpunit/phpunit-8.5-0/vendor/autoload.php
        # use InstalledVersions.php from project instead of of symfony/phpunit-bridge: https://github.com/phpstan/phpstan/discussions/4364
        - vendor/composer/InstalledVersions.php

[ossinkine]

PHPStan does not use InstalledVersions exactly the same as symfony/phpunit-bridge also does not use it. In my reproducer ProxyDumper from symfony/proxy-manager-bridge package used it and it was fixed. So if you create your own reproducer and we can find out who does actually use InstalledVersions the issue became more clear.

[niklasnatter]

I think in my case the sentry/sentry-symfony package does use the InstalledVersions. As far as i understand, the problem is that the symfony/phpunit-bridge includes a new InstalledVersions.php in its autoloader which overwrites the InstalledVersions.php of the project. After this, when the sentry/sentry-symfony package tries to read the version of sentry/sentry, the error happens.

See also the following issue: getsentry/sentry-symfony#383

[ossinkine]

Since symfony/proxy-manager-bridge stopped using InstalledVersions to fix this, maybe the best way would be also stop using InstalledVersions by sentry/sentry-symfony .