Return value of zip_open

[spud]

I have some code like this:

$zip = zip_open($file);
if (is_resource($zip)) {
   // do something
} else {
  // do something else
}

PHPStan flags this with Else branch is unreachable because previous condition is always true. with the implication that the return value of zip_open is always true (and a resource to boot). But the PHP docs indicate that zip_open can return false, or an error code as well (which is why I'm checking is_resource and not just boolean true).

Bug? Or am I thinking about this the wrong way?

[ondrejmirtes]

Hi, please send a PR that updates the function signature in https://github.com/phpstan/phpstan-src/blob/master/resources/functionMap.php, thanks :)