Getting undefined method from trait

[qrazi]

I am trying to increase PHPStan levels on my Craft CMS project. I am getting a "Call to undefined method yii\base\View::renderTemplate()." error on level 2 and I don't fully understand why. The project has a module that calls: Craft::$app->getView()->renderTemplate(). So I have control over the code in the module, but not over the Craft (and Yii2) framework code.

I recreated the error based on what happens in Craft: https://phpstan.org/r/f9b6528d-fb93-4e87-9509-6865f7c518e8 Updated example: https://phpstan.org/r/15d28429-4f99-4003-af4b-b6c006b5eb58

I am not sure if this is a bug, or if I should add type hints in the project code, or if this is something that needs to be fixed through a PHPStan extension? For the record, I started working on https://github.com/studio-stomp/phpstan-craftcms a while ago, so anything that needs to address the framework I could add to that.

[ondrejmirtes]

Hi, the class Application doesn't have renderTemplate method, so PHPStan is correct here. How come that it doesn't crash with an "undefined method" when running the app?

[qrazi]

So basically this is the issue: https://phpstan.org/r/12804d4e-022b-4163-9241-858ae2eab545

The playground also gives an error on the @mixin, which I do not get locally, but I think now it illustrates the PHPStan error that prompted my question.

I now also noticed the following comment in the CraftTrait file:
"Helps with IDE auto-completion."

Except for this @mixin adding in of CraftTrait, there is no type hints of sorts I see that show that it's actually Application that is loaded, and not YiiApplication.

So... My bad... 😅

To allow analysis I would need to stub Craft if I understand correctly?

[qrazi]

No, found another mistake in my example... Ugh... Super slow start of the year...

Not so much a mistake as my example not implementing it's own getView in YiiApplication; so what basically happens is this: https://phpstan.org/r/15d28429-4f99-4003-af4b-b6c006b5eb58

[ondrejmirtes]

What about: https://phpstan.org/r/4e3c0134-91b4-4406-96c7-6a3ee11923a7

[ondrejmirtes]

Or writing a stub file that changes the PHPDoc of Yii::$app: https://phpstan.org/user-guide/stub-files

[qrazi]

Thanks! I think I will have to go with stub route, as I can't change the Craft stuff either.