Cannot ignore line, cannot not ignore line

[judahnator]

I have this little snippet of code in a trait:

trait Commentable
{
    final protected static function bootCommentable(): void
    {
        static::deleted(static function (self $commentable): void {
            $softDeletes = in_array(SoftDeletes::class, class_uses(static::class));
            $forceDeleting = $softDeletes ? $commentable->isForceDeleting() : false;
            if (!($softDeletes xor $forceDeleting)) {
                $commentable->comments()->delete();
            }
        });
    }
    // ...
}

Running phpstan gives me this:

 ------ --------------------------------------------------------------------------- 
  Line   app/Support/Traits/Commentable.php (in context of class App\Models\Stock)  
 ------ --------------------------------------------------------------------------- 
  17     Call to an undefined method App\Models\Stock::isForceDeleting().           
 ------ ---------------------------------------------------------------------------

Now I know my code is fine, so if I tell phpstan to ignore that line...

$forceDeleting = $softDeletes ? $commentable->isForceDeleting() : false; // @phpstan-ignore-line

phpstan gives me the following:

 ------ -------------------------------------------- 
  Line   app/Models/Order.php                        
 ------ -------------------------------------------- 
  17     No error to ignore is reported on line 17.  
 ------ -------------------------------------------- 

 ------ -------------------------------------------- 
  Line   app/Models/Vendor.php                       
 ------ -------------------------------------------- 
  17     No error to ignore is reported on line 17.  
 ------ --------------------------------------------

What am I missing here?

[Kocal]

I think it's an issue with PHP-Parser, I remember a similar issue that have been recently opened here.
What happens if you try $forceDeleting = $softDeletes ? $commentable->isForceDeleting() /* @phpstan-ignore-line */ : false;?

[judahnator]

Huh, I would not have thought to give that a shot. Smart idea!

No change though, the same error occures.

[judahnator]

For a short-term solution, I just added the error to the "ignored errors" list in my phpstan.neon file. It's not ideal, but it works.

[ondrejmirtes]

Hello, I think that the problem is that:

• Class App\Models\Stock doesn't have isForceDeleting method.
• Classes Order and Vendor have that method.

Trait is analysed in context of each class that uses the trait, so PHPStan complains there's nothing to ignore when analyzing Commentable in the context of Order and Vendor.

You could change your code like this and get rid of the need for ignoring:

$forceDeleting = method_exists($commentable, 'isForceDeleting') ? $commentable->isForceDeleting() : false;

Let me know how it works :)

[judahnator]

Sure. This is what I get when using that method_exists method.

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   app/Support/Traits/Commentable.php (in context of class App\Models\Stock)                                    
 ------ ------------------------------------------------------------------------------------------------------------- 
  17     Call to function method_exists() with App\Models\Stock and 'isForceDeleting' will always evaluate to false.  
 ------ -------------------------------------------------------------------------------------------------------------