dynamicConstantNames parameter

[DJTommek]

Hi, I have this code, but I'm not able to make it valid for PHPStan (testing with 0.12.59)
Example: https://phpstan.org/r/4e1f6c23-ef86-457c-81c0-71a462b66f46
Result: 21 | Call to function is_null() with 'aaa' will always evaluate to false.

I tried using dynamicConstantNames in phpstan.neon as described in docs, but it just change error message to
21 | Call to function is_null() with string will always evaluate to false.

parameters:
	level: 8
	dynamicConstantNames:
		# - DefaultConfig::AAA
		# - \DefaultConfig::AAA
		# - DefaultConfig::*
		# - \DefaultConfig::*
		- Config::AAA
		# - \Config::AAA
		# - Config::*
		# - \Config::*
		# - AAA

Commented lines are just list what I tried to do.

What am I doing wrong, that PHPStan is not respecting PHPDoc and it's optional null? Thanks for response in advance.

[ondrejmirtes]

Yeah, PHPStan currently will generalize the type from 'aaa' to string, but it will not add null there...

[DJTommek]

Thanks for confirmation. Is that intended behavior?

I guess for all errors in my code could be solved using empty() instead of is_null(), but still - I don't like generalizing values like 0, null and empty string as same values and I couldn't use strict rules of PHPStan since empty() is not allowed.
Any ideas? If you need more context: DefaultConfig, "local" Config and some class with used is_null()

[ondrejmirtes]

I guess this will sort itself out once PHPDocs above class constants are read: #3530