Apply a rule like MatchExpressionNode to a method which accepts a condition as argument

[mglaman]

Related: mglaman/phpstan-drupal#734

Drupal has an AccessResult class with two methods that accept conditionals: allowedIf and forbiddenIf. I'd like to apply the same logic as MatchExpressionRule on these static methods. That way, we can catch faulty access check logic for always true or always false conditions.

I started exploring StaticMethodTypeSpecifyingExtension, but this returns an expression, not a node, that the rule would use.

[ondrejmirtes]

Please show a piece of code and expected result.

[mglaman]

Sorry, I have major conference brain fog. I realized I was probably looking at the wrong rule.

It's something more along the lines of StrictComparisonOfDifferentTypesRule. The $condition is a bool, probably from a binary operation. So, it's not an existing rule but a rule for those static method calls and inspecting the arguments. I'm leaving my draft notes in place just in case they're helpful.

Given this static method (source)

  public static function forbiddenIf($condition, $reason = NULL) {
    return $condition ? static::forbidden($reason) : static::neutral();
  }

If someone had the following code, it would produce something like Match arm comparison between %s and %s is always true.

AccessResult::forbiddenIf(false === false)

[ondrejmirtes]

So basically you want to make sure that the method is not called with something PHPStan already knows is truthy/falsy?

You can write a rule for StaticCall and check the first argument type:

$bool = $type->toBoolean();
$report = $bool->isTrue()->or($bool->isFalse())->yes();

[mglaman]

Thank you!