Deptrac integration - changing scope context while traversing node and BC promise #10680
Unanswered
patrickkusebauch
asked this question in
Support
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
I am working on Deptrac and in particular replacing the way AST parsing is done by the library.
Right now the parsing is done by Nikic PHP Parser and we try to keep track of all the scoping and namespaces ourselves.
I opened a PR that replaces this by calling PHPStan and taking advantage of its very robust
Scope
implementation.With the context out of the way, I have the following questions:
fails PHPStan checking.
ScopeContext
without breaking the BC promise?ScopeContext::enterClass
is not covered.especially with relation to how managing scope is handled. Experimentally it works, but there might be some edge cases that it might miss.
Beta Was this translation helpful? Give feedback.
All reactions